Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev2.5.17 all+server transl #203

Open
wants to merge 926 commits into
base: test2.5.17_toShowDiff_Allin
Choose a base branch
from

Conversation

hiroshisuga
Copy link
Owner

@hiroshisuga hiroshisuga commented May 31, 2023

What does this PR do?

#201 + #180 + #172

You may want to add bigbluebutton#17529 (or #204), which has recently received a bug fix.
and
hiroshisuga/bbb-playback#25
and
https://github.com/danielpetri1/bbb-recording-exporter
and probably
bigbluebutton#17862 and bigbluebutton#17864 (originally for 2.6)
Plus, bigbluebutton#18148, bigbluebutton#18151
Plus, #214
plus, #125 and https://github.com/hiroshisuga/bbb-playback/tree/externalvideo_marker_eraser_2.3.4
Plus #216 (or bigbluebutton#18180)
Plus #217 (or )
bigbluebutton#18284

Closes Issue(s)

Closes #

Motivation

More

  • Added/updated documentation

Don't translate interim transcript  which is veery long and inaccurate.
remove name from caption text
add avatar before caption
Create user/container.jsx
Create user/component.jsx
get whosText and captionText from {data}
add requesterUserId as a variable to modifier/setTranscript. It will be used to set 'whosText" of Captions.
add whosText in Captions
Fix: type check
pass object captionData: { captionText: formatCaptionsText(data), whosText: caption.whosText }, instead of the string formatCaptionsText(data).
caption bg translucent
revert alpha channel from default font background
add alpha channel to all font background color
remove minHeight for correct 2-line limitation in #212
add align-items: 'flex-end'
remove background="#000000a0", which does not do the job anyway after removing the size definition of avatar
set gap between avatar and caption
Add toggling fullscreen mode by a mouse double click. Useful for a hybrid presentation.
Fixes a bug that the styles of quick link button and its dropdown would not be transmitted to the detached window.
I tried at first to inject the styles, but it was a lot, so decided to show (render) them even when no URLs are written in slides. 
"disabled = true" did not allow rendering the dropdown, so I need to put a dummy item to the dropdown list.
Makes the button unclickable.
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 128 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant