forked from bigbluebutton/bigbluebutton
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev2.5.17 all+server transl #203
Open
hiroshisuga
wants to merge
926
commits into
test2.5.17_toShowDiff_Allin
Choose a base branch
from
dev2.5.17_All+serverTransl
base: test2.5.17_toShowDiff_Allin
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev2.5.17 all+server transl #203
hiroshisuga
wants to merge
926
commits into
test2.5.17_toShowDiff_Allin
from
dev2.5.17_All+serverTransl
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRAW_UPDATE can happen when the synchronised update option is turned on. And we don't need the hacky arg drawEndOnly parameter anymore, as now it is judged more precisely in the same way as in updateAnnotationPencil.
Don't translate interim transcript which is veery long and inaccurate.
1 task
Add toggling fullscreen mode by a mouse double click. Useful for a hybrid presentation.
Fixes a bug that the styles of quick link button and its dropdown would not be transmitted to the detached window. I tried at first to inject the styles, but it was a lot, so decided to show (render) them even when no URLs are written in slides. "disabled = true" did not allow rendering the dropdown, so I need to put a dummy item to the dropdown list.
Makes the button unclickable.
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#201 + #180 + #172
You may want to add bigbluebutton#17529 (or #204), which has recently received a bug fix.
and
hiroshisuga/bbb-playback#25
and
https://github.com/danielpetri1/bbb-recording-exporter
and probably
bigbluebutton#17862 and bigbluebutton#17864 (originally for 2.6)
Plus, bigbluebutton#18148, bigbluebutton#18151
Plus, #214
plus, #125 and https://github.com/hiroshisuga/bbb-playback/tree/externalvideo_marker_eraser_2.3.4
Plus #216 (or bigbluebutton#18180)
Plus #217 (or )
bigbluebutton#18284
Closes Issue(s)
Closes #
Motivation
More